rusefi icon indicating copy to clipboard operation
rusefi copied to clipboard

MSQ files from RE break MegaLogViewer - making veAnalyze impossible

Open ggurov opened this issue 1 year ago • 2 comments

Describe the bug MSQ files produced by TS from rusEFI do not work in MegalogViewer

Hardware

  • Board: uaefi
  • Engine info: 2jz-gte

To Reproduce Steps to reproduce the behavior: download http://rusefi.com/online/view.php?msq=1612 msq download https://rusefi.com/online/view.php?log=1348 log file

  1. open MegaLogViewer
  2. Notice table list on the very right of the dialog with "open tune" button:

image

  1. click "Open Tune"
  2. Browse to the MSQ downloaded
  3. Observe table list disappear and be blanked out.
  4. click "VE analyze"
  5. Observe: image

Expected behavior List of VE ignition advance and AFR target table be available for selection

Screenshots

image

making VE analyze from logs available to use:

image

Additional context VE analyze rules.

ggurov avatar Feb 20 '24 20:02 ggurov

this is happening because in the MSQ, RE saves RPM_bins and MAP_bins as

<constant cols="1" digits="0" name="veLoadBins" rows="16" units="kPa">

and <constant cols="1" digits="0" name="veRpmBins" rows="16" units="RPM">

and MLV needs it to be:

<constant cols="1" digits="0" name="frpm_table" rows="16" units="RPM">

and

<constant cols="1" digits="0" name="fmap_table" rows="16" units="kPa">

frpm_table -> veTable frpm_table1 -> veTable1

ggurov avatar Feb 20 '24 20:02 ggurov

these additions to the .ini file fix the MSQ that's produced by TS and no longer breaks MLV:

# for MLV
advanceTable = array, S16, 16568, [16x16], "deg", 0.1, 0, -20, 90, 1
fmap_table = array, U16, 17656, [16], "kPa", 1, 0, 0, 1000, 0
frpm_table = array, U16, 17688, [16], "RPM", 1, 0, 0, 18000, 0
smap_table = array, U16, 17080, [16], "Load", 1, 0, 0, 1000, 0
srpm_table = array, U16, 17112, [16], "RPM", 1, 0, 0, 18000, 0

#if LAMBDA
lambdaTable = array, U08, 17720, [16x16], "lambda", 0.006802721088435374, 0, 0.6, 1.5, 2
afrTable = array, U08, 17720, [16x16], "lambda", 0.006802721088435374, 0, 0.6, 1.5, 2
#else
lambdaTable = array, U08, 17720, [16x16], "afr", 0.1, 0, 0, 25, 1
afrTable = array, U08, 17720, [16x16], "afr", 0.1, 0, 0, 25, 1
#endif
lambdaLoadBins = array, U16, 17976, [16], "", 1, 0, 0, 1000, 0
lambdaRpmBins = array, U16, 18008, [16], "RPM", 1, 0, 0, 18000, 0

amap_table = array, U16, 17976, [16], "", 1, 0, 0, 1000, 0
arpm_table = array, U16, 18008, [16], "RPM", 1, 0, 0, 18000, 0

ggurov avatar Feb 20 '24 23:02 ggurov