Ralph Ursprung

Results 190 comments of Ralph Ursprung

oh, neat - i missed that chaining method! i think that's quite enough - or do you wish to keep this issue open and (eventually) add the varargs query builder...

interestingly enough i also get the same error in a second case: namely i get it when i _don't_ reference the analyzer from an `@Field` yet but have a `@Setting`...

see https://github.com/opensearch-project/spring-data-opensearch/pull/446 for a failing test case

@reta: see the provided test: it's not about what `opensearch-java` does internally. it's about the classes you try to ingest. without this you cannot serialise/deserialise any data which contains `java.time.*`...

> 1. The `opensearch-java` does not control user defined types (including Date/Time since this is not part of model) i agree. but JDK8 data types are part of the core...

> > if - after re-considering my arguments 😉 - you're still completely against adding the JDK8 & JSR310 modules as dependencies: would you at the very least accept adding...

i haven't reviewed the code, but: i think this is great, thanks! would it be possible to add documentation for it to the README? otherwise people will not notice that...

> > @reta Could you please review this PR ? > > @001mertiya the Micrometer has support of Apache HttpClient 5 metrics out of the box, it could be plugged...

> > oh, that's actually very interesting! is this something which could be enabled by default if micrometer is present? (maybe just in `spring-data-opensearch` if it needs some class/bean-presence checks?)...