Chris Thoburn

New Rule: `no-missing-external-imports`

1

There's [an existing eslint plugin for imports](https://github.com/benmosher/eslint-plugin-import/blob/master/README.md#settings), but it ignores imports from node_modules by default. It would be awesome if eslint-plugin-ember configured this rule to make it capable of resolving...

New Rule: no-self-referencing-properties

2

This rule would catch the issue that led to the bug in #1118 This rule would lint all macros as well as computed properties and getters for self-referential behavior. It...

New Rule: `no-controller-model-reads`

1

`reads` and `oneWay` are footguns if used in a controller to access a `model` property, because once changed they will no longer update when the `model` for the route changes....

New Rule: `no-simple-alias`

1

A new rule disallowing `oneWay` `reads` and `readOnly` off of another prop on the same context. ```js import Component from '@glimmer/component'; import { oneWay, reads, readOnly } from '@ember/object/computed'; export...

Error seen below: ``` Oops! Something went wrong! :( ESLint: 7.32.0 AssertionError [ERR_ASSERTION]: Node must be provided when reporting error if location is not provided at assertValidNodeInfo (/Users/runspired/github/private/fnb/frontend/node_modules/eslint/lib/linter/report-translator.js:98:9) at /Users/runspired/github/private/fnb/frontend/node_modules/eslint/lib/linter/report-translator.js:332:9...

partially resolves #1118 (we should still add a new rule)

[BUG] require-computed-macros can autofix to self-referential macros

3

Given the following (admittedly incorrect) computed usage ```js storeIds: computed("storeIds", "line", function() { return this.storeIds; }), ``` This rule will convert it to the following, which blows up since the...

[Bug] Integration tests visit application and index routes

1

I'm opening this here although it may more properly belong in either @ember/test-helpers, ember-cli, or ember-qunit. It's unclear which holds responsibility. As this is an "out of the box" behavior...

Better story for testing with lazy-loaded translations config

5

Currently for every test you must set the locale and await the fetch and add the translations, would be great to be able to do this more easily.

Error during initial app render: You attempted to update `_locale` on

1

Using the latest commit on master https://github.com/ember-intl/ember-intl/commit/1f6c801994f7be5a9ff780d066ae5f5f3c860f35 ``` Error: Assertion Failed: You attempted to update `_locale` on ``, but it had already been used previously in the same computation. Attempting...