datart icon indicating copy to clipboard operation
datart copied to clipboard

Published 20 hours ago • verified publisher icon running-elephant

Pivot metric sort menu lacks i18n support

Open clementchong opened this issue 2 years ago • 6 comments

Datart Version Demo site 1.0.0b3

Describe the bug Sort menu is hardcoded to chinese.

To Reproduce Steps to reproduce the behavior: See screenshots

Expected behavior Menu should display in correct language

Screenshots image

Environmental details: (optional, depending on where the bug occurs)

  • OS: [e.g. Windows 10]
  • Source Database: [e.g. MySQL 8.0.26]
  • Browser: [e.g. chrome 94, safari 15]

Additional context Add any other context about the problem here.

clementchong avatar May 30 '22 15:05 clementchong

There are antvis/S2 internal labels.

scottsut avatar May 31 '22 04:05 scottsut

ok, let me reach out to them

clementchong avatar May 31 '22 07:05 clementchong

Request accepted at https://github.com/antvis/S2/issues/1394

clementchong avatar May 31 '22 08:05 clementchong

Fixed by the team at antvis/S2, please help include in next build of datart.

https://github.com/antvis/S2/pull/1397

clementchong avatar Jun 02 '22 02:06 clementchong

Issue still there in beta 4

image

clementchong avatar Jul 21 '22 02:07 clementchong

应该是S2-v1.18.1版本修复了国际化这个问题，升级的事情我们近期评估下新版本。

Cuiyansong avatar Jul 31 '22 02:07 Cuiyansong