Dmitry Shirokov

Results 20 comments of Dmitry Shirokov
trafficstars

Closed due to age. If you're willing to contribute - please go ahead

I've added a note on strings to the README: https://github.com/runk/node-chardet/pull/103/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R74 Closing.

> is there an option to specify the path to existing DBs? Would you be able to elaborate how this'll work with this module? If you have files downloaded, the...

@crobinson42 @haoxins please review

Memory is cheap these days, and most cases require high performance for address lookup. With random fs reads it's nowhere close to desired performance. I used hybrid approach in the...

4x of the db size (512mb) sounds a bit excessive indeed. - Are you sure it's all attributed to maxmind lib? - Are you sure you initialise it once only?...

Did you experience a lot of reloads due to out-of-process file access operations?

Happy to accept the PR once tests fixed

This was merged by mistake and now reverted via https://github.com/runk/node-maxmind/pull/862