`finch version` e2e test failing consistently

[ginglis13]

Describe the bug The version test Check finch version [It] Should print finch version information is failing consistently in CI since 1b3ad94f9477eb3f8d33cbea90880f78ca403ff7.

This is odd because the values used to set the version appear to be fine:

https://github.com/runfinch/finch/actions/runs/5804355704/job/15733801308:

# This is Container e2e test, note no ".m" or ".modified"
go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.7.0-18-g1b3ad94 -X github.com/runfinch/finch/pkg/version.GitCommit=1b3ad94f9477eb3f8d33cbea90880f78ca403ff7" -timeout 30m ./e2e/container -test.v -ginkgo.v --installed="false"

# This is VM e2e test, note no ".m" or ".modified"
go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.7.0-18-g1b3ad94 -X github.com/runfinch/finch/pkg/version.GitCommit=1b3ad94f9477eb3f8d33cbea90880f78ca403ff7" -timeout 45m ./e2e/vm -test.v -ginkgo.v --installed="false"

Steps to reproduce

I haven't been able to reproduce locally.

Expected behavior

This test should pass.

Screenshots or logs

Additional context Test defined here: https://github.com/runfinch/finch/blob/main/e2e/vm/version_test.go

[ginglis13]

We haven't seen this issue since CI on the day this issue first presented itself. Working theory is concurrent builds interfered with each other in the GHA work directory, causing modification of finch builds. TODO is investigating and implementing a fix for our theory.