feat: Print version with Client and Server

[ahsan-z-khan]

Issue #, if available: #12

Description of changes: Use nerdctl version with addition of finch version

Testing done: Yet to be updated

• [x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ningziwen]

I added one comment to the issue. I think we should close the final output format first before reviewing the PR.

[ahsan-z-khan]

Note: Lint passed locally for nolint but failing in CI

[pendo324]

Note: Lint passed locally for nolint but failing in CI

The linting error looks pretty weird. Let's try retrying it after the other workflows finish

[ahsan-z-khan]

Note: Lint passed locally for nolint but failing in CI

The linting error looks pretty weird. Let's try retrying it after the other workflows finish

It's weird that it was passing before the latest push on main. Not sure if that has something to do

[ahsan-z-khan]

Note: Lint passed locally for nolint but failing in CI

The linting error looks pretty weird. Let's try retrying it after the other workflows finish

According to this: https://github.com/golangci/golangci-lint-action/issues/23

Setting 'skip-pkg-cache: true' on each run of the golangci-lint action seems to fix it. We have it setup as 'false'. Another solution is to config the go-linter in a separate action.

[davidhsingyuchen]

Note: Lint passed locally for nolint but failing in CI

The linting error looks pretty weird. Let's try retrying it after the other workflows finish

According to this: golangci/golangci-lint-action#23

Setting 'skip-pkg-cache: true' on each run of the golangci-lint action seems to fix it. We have it setup as 'false'. Another solution is to config the go-linter in a separate action.

If we run make lint locally, some fixes are triggered, which means that it won't pass in CI. That line will be removed after addressing https://github.com/runfinch/finch/pull/108#discussion_r1066452161 anyway.

➜  finch git:(version_extension) make lint
golangci-lint run
➜  finch git:(version_extension) ✗ git --no-pager diff
diff --git a/cmd/finch/main.go b/cmd/finch/main.go
index 5b0f274..83c6889 100644
--- a/cmd/finch/main.go
+++ b/cmd/finch/main.go
@@ -39,7 +39,7 @@ func main() {
 	}
 }

-//nolint: lll //Line is more than 150 character
+// nolint: lll //Line is more than 150 character
 func xmain(logger flog.Logger, ffd path.FinchFinderDeps, fs afero.Fs, loadCfgDeps config.LoadSystemDeps, mem fmemory.Memory, stdOut io.Writer) error {
 	fp, err := path.FindFinch(ffd)
 	if err != nil {

[ahsan-z-khan]

6 e2e tests are failing on arm64 which are not related to the PR. They demonstrate the behavior of Issue #140 .