lit-analyzer icon indicating copy to clipboard operation
lit-analyzer copied to clipboard

aria-haspopup no-incompatible-type-binding false alarm

Open pmcelhaney opened this issue 4 years ago • 3 comments

The following code triggers Type '"listbox"' is not assignable to '"true" | "false"'lit-plugin(no-incompatible-type-binding)(2304).

<button aria-haspopup="listbox"></button>

That's not accurate. aria-haspopup can several values other than "true" or "false".

https://www.w3.org/TR/wai-aria/#aria-haspopup

I did a quick scan through the code and it looks like the bug may be in an upstream dependency. If someone can point me in the right direction I'll open a PR.

pmcelhaney avatar Sep 30 '20 19:09 pmcelhaney

I second this issue, I am getting the same error.

Screen Shot 2021-03-26 at 9 59 18 AM

bradniksa avatar Mar 26 '21 14:03 bradniksa

I've made a PR for this: https://github.com/runem/lit-analyzer/pull/175

joekukish avatar Jun 09 '21 12:06 joekukish

@rictic just a heads up I am pretty sure release v2.0.1 fixed this issue and it and #175 can both be closed now.

brentswisher avatar Dec 05 '23 21:12 brentswisher