runelite
fix: hide walk here target name with condensed options
Does doing
type != MenuAction.WALK_HEREinstead work too?
Yeah looks like it does, I'll change that
This isn't what I meant. I meant adding it to line 163.
How's this?
Does it work if you delete all of your changes except for this?
This isn't what I meant. I meant adding it to line 163.
How's this?
Does it work if you delete all of your changes except for this?
No, we need to keep track of the first one so we can add it back to the top of the menu
In #19156 is mentioned the following with regards to "lifting" the walk here option out of the player submenus:
I don't think that works since the "Walk here" option for different players could potentially target different tiles?
Did you test whether this change impacts "walk here" on multiple players targeting different tiles? Let's say your camera is at a low angle and you can right-click multiple players who aren't on the same tiles due to the angle. Does walk here always go to the same tile in vanilla and the old implementation of the plugin?
Let's say your camera is at a low angle and you can right-click multiple players who aren't on the same tiles due to the angle.
No matter how many players you catch with your right click, there is only ever one "Walk here" option, which takes you to the tile your cursor was over when you right clicked. It doesn't matter what tiles the players are on. Simply moving it out of any submenus should be fine.
#19156 is a bug about this:
Where there is a duplicate player in the menu with just "Walk here". Doing the change I suggested changes it to this:
Which I think effectively fixes it. I don't understand why you are trying to reorder walk here over top of the object op. That shouldn't happen and just isn't how the game works really at all, the left click option should be the object op.
Where there is a duplicate player in the menu with just "Walk here". Doing the change I suggested changes it to this:
That works as a fix.
Which I think effectively fixes it. I don't understand why you are trying to reorder walk here over top of the object op. That shouldn't happen and just isn't how the game works really at all, the left click option should be the object op.
Partially was to make walk here easier to find, always being at the top. It doesn't change the left click option, but does make it so the top option isn't the left click option, which breaks convention for sure.
If we don't like the reorder (which I totally get), happy to remove it!
What are your thoughts on removing the walk here target? So it just says "Walk here" rather than "Walk here PlayerName"
Partially was to make walk here easier to find, always being at the top. It doesn't change the left click option, but does make it so the top option isn't the left click option, which breaks convention for sure.
But this isn't actually the convention. Eg here is the vanilla menu:
Notice Walk here isn't on top.
What are your thoughts on removing the walk here target? So it just says "Walk here" rather than "Walk here PlayerName"
This is fine
