runelite
Added BankStats plugin to plugin hub
Firstly I want to apologize for submitting so many PRs, and forking multiple times. I wasn't sure how to update a failed PR. I'm just (re) learning git, and java alongside it. I'm pretty confident that this PR was done correctly, but if I've done anything wrong I would appreciate any guidance. I've worked hard on this plugin and I'm looking forward to sharing it with friends and clanmates, so please don't black list me for my unintentional spam.
Description: This plugin allows you to track the changes in price of all items in your bank over any interval. You take snapshots and then compare whenever you want, letting you know which items are causing your bank to move up or down, potentially helping you make buying or selling decisions. All the data is given in sortable tables that make it easy to process quickly, including large format popup windows to give you a full screen view. Also, there is roughly 15 market data points provided on all items in your bank, letting you know at a glance what's happening in the market. In the next version, there will be an alert builder that allows you to create custom market alerts, letting you find your desired entry or exit points easily, taking away the need to refresh a third party website every hour. I've attached a screenshot and short video for anyone curious as to how my creation looks! (I'm a total java beginner so it took me a long time).
Appreciate all the work you guys do, cheers.
(Sorry for the full screen recording, it was the only way to capture the popup windows)
https://github.com/user-attachments/assets/dbeb41c9-e93a-443b-bb50-b0ee23ca4bba
Includes changes by non-author
New plugin bankstats: https://github.com/AaronDemond/BankStats/tree/3a16a9f61e3354ab04cf0ab51c733b4744d28a69
![runelite-github-app[bot] avatar](https://avatars.githubusercontent.com/u/13814776?v=4 "Published by a pub.dev verified publisher"){kind=small}
To answer the question you've asked on a bunch of your other PRs here since this is the open one:
CI isn't running because you're using a brand new GitHub account, so it requires one of the maintainers to approve it before running.
If you need to make any changes, push them to the branch that you've made to this PR. Please do not open any additional PRs, and keep all conversation here rather thank trying to ask across half a dozen other PRs.
To answer the question you've asked on a bunch of your other PRs here since this is the open one:
CI isn't running because you're using a brand new GitHub account, so it requires one of the maintainers to approve it before running.
If you need to make any changes, push them to the branch that you've made to this PR. Please do not open any additional PRs, and keep all conversation here rather thank trying to ask across half a dozen other PRs.
Got it. Thanks. Do I have to do anything other than push to the branch in my forked plugin-hub repository after making changes? Or is that enough to trigger an update that will be looked at? How long does it take to get a maintainer to approve my CI (tests?). Do they have to review my entire code base first? (I apologize in advance, its a bit of a mess, but I'm completely new to java. I'm happy to make any changes required.
Your plugin does not build. Please test your changes locally before submitting or updating a plugin. Do not close this PR, just fix it and push the changes.
I would assume your build fails because you are using a non-conforming build.gradle that looks LLM generated possibly.
Use what's represented in the example plugin https://github.com/runelite/example-plugin/blob/39a7b624976263b30157ad5d79f510f6f1779b03/build.gradle and read the developer wiki on how to run your plugin. Especially since it appears you are using intellij.
still broken chief
click this link and look at the failure - you can push as many commits as you need to this PR to fix things until that build check passes
still broken chief
click this link and look at the failure - you can push as many commits as you need to this PR to fix things until that build check passes
Okay I think I have it now. My icon was too high resolution, that was it. Ill push a fix shortly.
I have a question. Is it an issue that the repo is owned by a different account than the one I'm using to make the PR?
You are aware that this is still broken right? Nobody is looking at it until that build check is green.
You are aware that this is still broken right? Nobody is looking at it until that build check is green.
Yes sorry I've been away and havent been able to work on it. I will push a fix shortly.
Closing because this is still broken.
If you fix the build issues in the future then you may resubmit this plugin in a new PR.
If you do so, and then encounter further build issues or other issues with the submission, for the love of god, DO NOT then close and open 10 new PRs to update your plugin. Just update the commit hash in your plugin-hub fork.