runelite
add modern-chat
Preview Video
Features without the Modern Design
Note: Keystrokes are NOT captured in the chat input while the chat is hidden
Note: Toggle keybind can be changed in the settings, it defaults to Enter
Note: Private Chat Anchoring can be enabled/disabled in the settings
Note: When the Fade setting is enabled the peek overlay will reappear when a new message is received in the chat
Note: /pm chats can be closed using Escape key or submitting an empty message
Note: Previous / next keybinds can be configured in the settings
Note: Private chats can be closed using Escape key or submitting an empty message
New plugin modern-chat: https://github.com/BenDol/Modern-Chat/tree/e87d0684ccc810cfa75d33c6ea5ffd462d15e034
![runelite-github-app[bot] avatar](https://avatars.githubusercontent.com/u/13814776?v=4 "Published by a pub.dev verified publisher"){kind=small}
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.
Internal use only: Reviewer details Maintainer details
Being able to copy and paste into chat isn't going to be allowed
Also I don't have time to review this based on size alone
Being able to copy and paste into chat isn't going to be allowed
Also I don't have time to review this based on size alone
Even though there's an 80 character limit and a spam block mechanism that mutes messages when spamming? Not sure I understand the copy paste issue. I could add restrictions to pasting links into chat, but removing a basic function like copy and paste seems odd.
It's considered auto typing and we have denied this feature from several plugins.
It's considered auto typing and we have denied this feature from several plugins.
is this a Jagex classification?
Yes Generates input to our game applets. This includes software that automatically moves the mouse pointer or generates mouse clicks or key presses.
Yes
Generates input to our game applets. This includes software that automatically moves the mouse pointer or generates mouse clicks or key presses.
Okay this seems very odd to me, but I can remove pasting support to meet the requirement. Thanks
It also looks like you have your own input buffer that completely bypasses jagex chat services? Which I'm not sure that would be inherently good.
It also looks like you have your own input buffer that completely bypasses jagex chat services? Which I'm not sure that would be inherently good.
Yeah I try to keep them in sync, mainly just use the buffer for the caret (cursor) positioning, etc. Although I might be missing a sync event from the var string to my input. I'll double check this whole strategy.
Quick update. From my testing over the past few days, things are seeming stable, I resolved any issues I ran into. I am willing to maintain this plugin for as long as possible going forward if it is accepted. I look forward to some feedback soon, no rush obviously since I know its a larger project.
I am just excited to get the plugin reviewed and added when ever possible 🚀 The video I posted got 500 views organically, I didn't share the video anywhere except here and one small discord server, so it seems people would be excited for a plugin to help improve their chat experience. Thanks for taking the time!
Can we bump this? It's been like 2 months since the last activity from RL devs. Was looking forward to this plugin
@BenDol can you confirm where you sourced the sounds from? We need to ensure they are licenseable.
@BenDol can you confirm where you sourced the sounds from? We need to ensure they are licenseable.
Done, let me know if its all good. I can always remove the packaging of sounds but retain support to add your own sounds if its too complicated to license.
Do we think this will be reviewed before OSOSRSRS comes out? 😂
Given that Sailing updates are being given priority right now and that this is a massive, massive, massive PR, it will probably take a very long time for this to get added to RL.
It may be worthwhile for the dev to start with a more basic version of the plugin that's easier to review and add to that over time.
I understand wanting to prioritize sailing plugins - but there is already the new main sailing plugin, released last week. How many more sailing plugins need priority over non sailing plugins?
This PR has been open for 4 months. Just review it already, or tell the developer no
The delay in reviewing this plugin has nothing to do with Sailing. It's held up because it has potential concerns around tripping the auto-typing anticheat as raiyni pointed out above. This plugin needs an amount of time to review which is unusually large compared to others to make sure we aren't going to have issues after merging. When someone (a volunteer!) has the time, the knowledge, and the patience to review only this plugin, it will get reviewed.
Trust me, I'm aware it's here, and I don't want it to sit here forever either:
Side note: Yes, the "Sailing" plugin is massive too, but it's not like it skipped the line because we were "prioritizing Sailing plugins"; it skipped the line because I (a maintainer) wrote it, and therefore I don't need to review it in the first place. That would be a bit pointless.
Trust me, I'm aware it's here, and I don't want it to sit here forever either:
Thanks for the update, it's most appreciated! Let me know if there's anything I can do to help with the process at all. Otherwise I'll be here for whenever its able to get some traction.