plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create ladydragontracker

Open SonderAu opened this issue 1 year ago • 6 comments

First stable build of account tracker for clan. Using HTTPS, sends players xp values of skills to backend server which gets stored in values. Intended for semi-private (within osrs clan) use until backend moved to public repositories.

SonderAu avatar Oct 09 '24 00:10 SonderAu

New plugin ladydragontracker: https://github.com/SonderAu/ladydragon/tree/602a3fac74fbe5c37cb09d1afb46420d2ae215f0

Would wise old man groups and API usage be better for your clan?

raiyni avatar Oct 09 '24 00:10 raiyni

The consensus from a few of the more savvy leaders is that they want the data housed locally. The React frontend gives them more functionality than tools like CML and WOM. Previous "workaround" was running GroupIronman.Men with a couple different groups, however this has pushed past the scope of that.

SonderAu avatar Oct 09 '24 00:10 SonderAu

Why not just grab it from the highscores with a script then? I don't really see a need for this to be an entirely separate plugin, when an external Python script or something if the sort could achieve the same thing.

cdfisher avatar Oct 09 '24 00:10 cdfisher

Understandable, in its current form its quite raw and doing the absolute basics. Our implementation theory was to get the basics in to the community-hub and continue expanding from there, leveraging the review/build process runelite does to mitigate any major design issues we'd run into. Ultimately we're simply doing a fork of https://github.com/christoabrown/group-ironmen-tracker but due to it deviating from not using his backend/frontend deployment understood it to mean we couldn't "piggyback" off that commit without the clan having to run local builds. The primary difference in external scripting vs within RL, was to us just real-time vs scheduled scripting to scrape someone elses endpoint (be it hiscores, WOM, or CML). Forgive me for the block text, just trying to add context.

SonderAu avatar Oct 09 '24 00:10 SonderAu

  • Use a more specific config group, like "ladydragon" https://github.com/SonderAu/ladydragon/blob/602a3fac74fbe5c37cb09d1afb46420d2ae215f0/src/main/java/com/ladydragon/LadyDragonConfig.java#L7
  • Remove the default url, even though it's localhost, and do nothing if it is left blank https://github.com/SonderAu/ladydragon/blob/602a3fac74fbe5c37cb09d1afb46420d2ae215f0/src/main/java/com/ladydragon/LadyDragonConfig.java#L18
  • Replace println calls with log.debug https://github.com/SonderAu/ladydragon/blob/602a3fac74fbe5c37cb09d1afb46420d2ae215f0/src/main/java/com/ladydragon/LadyDragonPlugin.java#L73
  • Not strictly necessary, but you can craft json using JsonObject or gson.toJson(someValueClass) instead of string interpolation, to handle proper escaping of e.g. quotation marks https://github.com/SonderAu/ladydragon/blob/602a3fac74fbe5c37cb09d1afb46420d2ae215f0/src/main/java/com/ladydragon/LadyDragonPlugin.java#L141
  • don't use printStackTrace, the log.error already will https://github.com/SonderAu/ladydragon/blob/602a3fac74fbe5c37cb09d1afb46420d2ae215f0/src/main/java/com/ladydragon/LadyDragonPlugin.java#L151

LlemonDuck avatar Oct 15 '24 22:10 LlemonDuck

closing as the above comments have not been resolved yet. feel free to resubmit when they are

LlemonDuck avatar Nov 12 '24 03:11 LlemonDuck