plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Added Better Custom Cursor

Open archiru opened this issue 1 year ago • 6 comments

This plugin allows users to specify where they want their cursor to point, for images like crosshairs ect.

archiru avatar Sep 13 '24 16:09 archiru

New plugin better-custom-cursor: https://github.com/archiru/better-custom-cursor/tree/8c3d2552bf46ff6a5a3785df20067feab88fbed9

Before a reviewer even really looks through this, can you clean up all the example plugin stuff from the repo? You're basically bundling the whole example plugin along with what you've written.

~~Also, is there a reason your plugin's license headers are dated 2018 and seem to only name someone who appears to mostly write WoW add-ons?~~

Editing to add I failed to check core on that one.

cdfisher avatar Sep 13 '24 17:09 cdfisher

Thank you, I have now removed the example plugin from the repo, I mistakenly merged.

archiru avatar Sep 13 '24 18:09 archiru

What does this plugin do that the core plugin, or other cursor plugins on the hub don't already do? Also, could you come up with a more descriptive name? (I know this can be difficult)

YvesW avatar Sep 14 '24 04:09 YvesW

This plugin allows the user to change where they want the cursor to click. By default, the custom cursor plugin assumes that cursor starts at 0,0, which is not the case for many custom images, such as crosshairs or arrows.

I will change the name of the plugin, Thank you

archiru avatar Sep 14 '24 10:09 archiru

Your build is failing because you are using enabledByDefault = false. You can check the results under the details of the RuneLite Plugin Hub Checks check suite.

LlemonDuck avatar Oct 13 '24 00:10 LlemonDuck

closing as the above comments have not been resolved yet. feel free to resubmit when they are

LlemonDuck avatar Nov 12 '24 03:11 LlemonDuck