plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Add chunk-tasks plugin

Open nathanreidok opened this issue 1 year ago • 7 comments

Plugin for one-chunk accounts to track tasks imported from the chunk picker site. Player will be notified with a collection log style popup when a task is either auto-detected as complete or manually checked off.

nathanreidok avatar Jun 17 '24 20:06 nathanreidok

New plugin chunk-tasks: https://github.com/nathanreidok/chunk-tasks/tree/525b2254da096fcaf91176d97dce78d694fb63be

quick review: You can't use example as your config group, and there's a couple other example's as well

Felanbird avatar Jun 20 '24 18:06 Felanbird

@Felanbird thanks for the review. Replace all the "example"s

nathanreidok avatar Jun 20 '24 19:06 nathanreidok

I've not done an extensive review, but make sure to remove the NavButton on plugin shutdown.

YvesW avatar Jun 20 '24 20:06 YvesW

@YvesW updated to remove NavButton on shutdown

nathanreidok avatar Jun 20 '24 20:06 nathanreidok

We don't allow reflection on the hub

Bram91 avatar Jun 28 '24 20:06 Bram91

@Bram91 - good to know! Removed reflection from the plugin.

nathanreidok avatar Jun 28 '24 20:06 nathanreidok

https://github.com/nathanreidok/chunk-tasks/blob/50872f225a2b8377b7c80750f3af3c34a5fd993d/src/main/java/com/chunktasks/panel/ChunkTasksPanel.java#L347-L350

https://github.com/nathanreidok/chunk-tasks/blob/50872f225a2b8377b7c80750f3af3c34a5fd993d/src/main/java/com/chunktasks/managers/ChunkTasksManager.java#L37-L39

Use ChunkTasksPanel.getResourceAsStream and ChunkTasksManager.getResourceAsStream, respectively

LlemonDuck avatar Jul 15 '24 06:07 LlemonDuck

@LlemonDuck removed one getResourceAsStream that wasn't needed and updated the other.

nathanreidok avatar Jul 19 '24 23:07 nathanreidok