plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create loot-lens

Open Zzeetaa opened this issue 1 year ago • 2 comments

a simple plugin which adds a sound effect from the content creator lens when opening chests in the gauntlet

Zzeetaa avatar Jun 03 '24 21:06 Zzeetaa

New plugin loot-lens: https://github.com/Zzeetaa/loot/tree/f050d97ef33e682abd533d25a46dfa9098eb7598

consent

proof of permission

Zzeetaa avatar Jun 06 '24 22:06 Zzeetaa

LootConfig#greeting is unused and you should not use example as the config group: https://github.com/Zzeetaa/loot/blob/f050d97ef33e682abd533d25a46dfa9098eb7598/src/main/java/com/loot/LootConfig.java#L7

perhaps the clip volume should be adjustable via config

to read the wav resource, you should use getResourceAsStream because new File("src/main/resources/sound/loot.wav") will not work as explained here: https://github.com/runelite/plugin-hub?tab=readme-ov-file#plugin-resources

iProdigy avatar Jul 15 '24 01:07 iProdigy

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

LlemonDuck avatar Jul 29 '24 16:07 LlemonDuck

Closed at author request.

MESLewis avatar Oct 02 '24 19:10 MESLewis