DropTracker re-write

[joelhalen]

Re-wrote the entire plugin to remove lots of excess code and messy logic. Used a lot of code to rewrite from Adam's Discord Loot Logger.

All players' drops are now tracked via our Discord webhook system, and players can enable their own "discord loot logger"-style webhook notifications for drops if they don't have a clan or don't want to use the Discord bot.

Players can sign up for events in our Discord server, which are centered around drops/pvm content.

Implemented a new side panel with enhanced functionality and much better management of thread usage to prevent latency issues that many users were reporting with the API enabled

[runelite-github-app[bot]]

droptracker: 0f05faead8821b3cf57fa5e6cbff3e8a30391f66...dffaecd07eef3b2101188b715c3d80b7dc208698

[Nightfirecat]

You can't use null.com as an "invalid" domain; https://null.com is a real website. Please ensure your plugin is not sending unwanted outbound connections when your config is not set up to do so. The chat commands you're registering in your plugin are never unregistered; please do so in your plugin's shutDown method. Your plugin panel is registered to the event bus on init but is never unregistered. (deinit() is never called) Please ensure it is unregistered when it is removed and/or on plugin shutDown.

[joelhalen]

You can't use null.com as an "invalid" domain; https://null.com is a real website. Please ensure your plugin is not sending unwanted outbound connections when your config is not set up to do so. The chat commands you're registering in your plugin are never unregistered; please do so in your plugin's shutDown method. Your plugin panel is registered to the event bus on init but is never unregistered. (deinit() is never called) Please ensure it is unregistered when it is removed and/or on plugin shutDown.

Apologies for that oversight; should be fixed. I've defaulted the API to use an empty url and made sure the commands and side panel are both removed on shutdown.

Thanks for your time

[Nightfirecat]

You were already removing your plugin's nav button on shutDown, however you are never calling panel.deinit(), so it remains subscribed to the event bus.

[joelhalen]

You were already removing your plugin's nav button on shutDown, however you are never calling panel.deinit(), so it remains subscribed to the event bus.

Ah alright; took care of that. Thanks for your patience.

[Nightfirecat]

This will cause an NPE (because you nulled it the line before) and not deinit it.