plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Create GodlikeHttp

Open bastianjoergensen opened this issue 1 year ago • 8 comments

A HTTP server plugin

bastianjoergensen avatar Jan 23 '24 12:01 bastianjoergensen

New plugin godlikehttp: https://github.com/bastianjoergensen/GodlikeHttp/tree/ffc4e99eaba52567643728296a7929ddc7235225

What is this plugin doing? It looks like it just writes events to files locally? If so, you don't need like 85% of this code.

raiyni avatar Jan 23 '24 13:01 raiyni

What is this plugin doing? It looks like it just writes events to files locally? If so, you don't need like 85% of this code.

It starts a HTTP server that you can make requests to, to get the players info etc.

But enlighten me, I want to learn. :)

bastianjoergensen avatar Jan 23 '24 13:01 bastianjoergensen

There's already two different plugins that do something similar that might be what you want?

https://github.com/MW90-NL/httpeventserver.git

https://github.com/Adam-/runelite-plugins/tree/http-plugin

raiyni avatar Jan 23 '24 13:01 raiyni

They aren't really the same, I think. I also think theirs is pretty poorly written (not trying to be rude, sorry), and not easily extendable.

bastianjoergensen avatar Jan 23 '24 14:01 bastianjoergensen

Added the missing license

bastianjoergensen avatar Feb 04 '24 19:02 bastianjoergensen

Why are you creating a separate EventBus instance instead of @Injecting it? You can still manually register and unregister classes to the injected instance.

Nightfirecat avatar Feb 22 '24 06:02 Nightfirecat

Why are you creating a separate EventBus instance instead of @Injecting it? You can still manually register and unregister classes to the injected instance.

I simply didn't know, will definitely try that!

bastianjoergensen avatar Feb 22 '24 07:02 bastianjoergensen

Closing due to inactivity. Feel free to re-open this PR if you get around to making the noted changes.

Nightfirecat avatar Apr 12 '24 21:04 Nightfirecat