plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Published 20 hours ago • verified publisher icon runelite

Updated Bone Runner Plugin

Open Elrol opened this issue 1 year ago • 4 comments

Added host overlay to show who is hosting for runners

Elrol avatar Dec 07 '23 11:12 Elrol

Includes non-plugin changes

bone-running: 9e9f427525c0b7df8f1ab40be317f2603f0dfa70...5363e0761519fb8f929421b6143ea3a25ee898ec

runelite-github-app[bot] avatar Dec 07 '23 11:12 runelite-github-app[bot]

This change would prevent your plugin from being unloaded as it is registered with java.sql's DriverManager but never unregistered. Furthermore, it leaks jdbc connections. We're hesitant to support (and add a substantial new dependency for) a plugin which uses plaintext credentials to connect directly to a mysql database, even if it is read-only. Can't this data be served via http?

Nightfirecat avatar Feb 04 '24 05:02 Nightfirecat

The data that is being sent isn't anything confidential, but we want the data to not be able to be changed by others. Its basically to keep track of user stats when running bones so we can have a leaderboard kind of thing.

Could you point me in the right direction to send this data using http?

Elrol avatar Feb 04 '24 20:02 Elrol

By "sending data over HTTP", I meant serving a static file, or something of the sort. (this file could be generated and updated by a server as changes are needed) A server script could also generate and deliver data from the mysql database over HTTP.

Nightfirecat avatar Feb 05 '24 20:02 Nightfirecat