plugin-hub icon indicating copy to clipboard operation
plugin-hub copied to clipboard

Published 20 hours ago • verified publisher icon runelite

Plank Alerts Plugin

Open ANWAQ opened this issue 3 years ago • 12 comments

Plugin to screenshot deaths during COX / TOB raids and post them to a discord webhook.

ANWAQ avatar Feb 20 '22 00:02 ANWAQ

New plugin plank-alerts: https://github.com/ANWAQ/Plank-Alerts/tree/38ca686f37aaf5f3672d2b7dcd913919897ce29d

runelite-github-app[bot] avatar Feb 20 '22 00:02 runelite-github-app[bot]

You should be using the provided okhttp client via @Inject OkHttpClient client instead of making your own.

Adam- avatar Feb 20 '22 00:02 Adam-

You should be using the provided okhttp client via @Inject OkHttpClient client instead of making your own.

Thanks! First time contributing, let me know if that looks good.

ANWAQ avatar Feb 20 '22 00:02 ANWAQ

This exists as discord-death-notifications already?

raiyni avatar Feb 21 '22 15:02 raiyni

I didn't know about that plugin, and I did my research on this as well, as I mention in my plugins readme there already exists a raidshamer plugin that does something similar but that project seems to be abandoned and lacks lots of functionality.

My plugin differs from discord-death-notifications in that it:

  • Is specific to raids
  • Captures deaths of any person in your raid, not just your own character
  • Adds additional data about what room in the raid the death occurred

I have plans of updating it to keep track of how many points each death lost the group as well, and possibly other changes and raids 3 integration in the future. I can agree there shouldn't be 3 separate discord webhook death notifiers in the plugin hub, I think discord-death-notifications can maintain it's role as a generic, runescape wide death notifier, but my plugin would now supersede raidshamer and make it obsolete (I wouldn't mind just submitting my updates into raidshamer where they rightfully belong, but there is already a year old stagnant PR to just add COX support).

ANWAQ avatar Feb 21 '22 21:02 ANWAQ

This would be a good candidate to merge into/take over raidshamer I think. They have a small established user base of ~2k people.

raiyni avatar Feb 23 '22 15:02 raiyni

Totally agree with you, are you suggesting I rename this plugin to raidshamer so any future downloads go to my repo instead of the old one, or how would such a change be implemented?

ANWAQ avatar Feb 23 '22 21:02 ANWAQ

@raiyni Any updates on this?

ANWAQ avatar Mar 21 '22 01:03 ANWAQ

His suggestion is that you submit this feature as a change to https://github.com/ejedev/raidshamer, and ejedev would push that as an update to the available hub plugin to be included for users who already have that plugin installed.

Nightfirecat avatar Mar 22 '22 05:03 Nightfirecat

His suggestion is that you submit this feature as a change to https://github.com/ejedev/raidshamer, and ejedev would push that as an update to the available hub plugin to be included for users who already have that plugin installed.

That project has been abandoned, as I said above.

ANWAQ avatar Mar 24 '22 02:03 ANWAQ

They seem to be active on GitHub, just not on that repository. I'd be fine with you taking ownership of that plugin with their permission. @ejedev, are you fine with that?

Nightfirecat avatar Mar 27 '22 03:03 Nightfirecat

@Nightfirecat Apologies for the delay, that is fine with me. I unfortunately don't have time to maintain it anymore.

ejedev avatar May 11 '22 06:05 ejedev

Bumping this thread since I'm looking to add TOA support to this plugin. @ANWAQ are you still looking to take over the plugin?

jack0lantern avatar Nov 27 '22 04:11 jack0lantern

@Nightfirecat I've been in conversation with @ejedev and he said it'd be cool for me to take over if @ANWAQ isn't able to

jack0lantern avatar Nov 30 '22 04:11 jack0lantern

Raidshamer has been updated by @jack0lantern to include TOA, so this is effectively done in my eyes.

Nightfirecat avatar Dec 09 '22 22:12 Nightfirecat