rune
rune copied to clipboard
`Diagnostics::runtime_used_deprecated()` being called for many, likely all, function calls.
Root caused by @setbac (discord name).
Diagnostics::runtime_used_deprecated() is being called for apparently all function calls.
Instead, either
(a) calling code should filter the hashes before calling this method (if the execution engine even has that information available, which I don't know), or
(b) Diagnostics needs to take on the role of collecting the hashes at runtime and filtering them when emit()ing them. That seems like it would have a significant memory and performance impact, and runtime_used_deprecated() would need to be renamed to indicate its expanded role.
For reference, here's the original PR: https://github.com/rune-rs/rune/pull/685. It clearly indicates that (b) was the intended approach.