node-testrail-api icon indicating copy to clipboard operation
node-testrail-api copied to clipboard

[Discussion] Provide response status code for each api call

Open NicoAiko opened this issue 7 years ago • 6 comments

Hello there again.

Do you mind if we add some more response to each api call? As it is right now, we can't deal different status codes as the package just doesn't sends them through with the response's body.

I'll do a Pull Request for it, if you don't mind. We can discuss further then.

NicoAiko avatar Feb 05 '18 12:02 NicoAiko

Hi,

Yes, I don't mind. Don't forget to update the unit tests according to your changes.

Thanks for the help ! :)

rundef avatar Feb 07 '18 02:02 rundef

#8

NicoAiko avatar Feb 19 '18 14:02 NicoAiko

Now my typings fail.

Before:

let testrail: TestRail;
let tests: ITest[];

testrail = new TestRail(params);
tests = await testrail.getTests(123, {})

Now

let testrail: TestRail;
let tests: ITest[];

testrail = new TestRail(params);
tests = (await testrail.getTests(123, {}) as any).body

Sad.

tymfear avatar Mar 27 '18 17:03 tymfear

@tymfear The types should be fixed by #10

NicholasBoll avatar Apr 16 '18 15:04 NicholasBoll

I think this Issue can be closed now that #8 and #10 are merged

NicholasBoll avatar Apr 16 '18 15:04 NicholasBoll

Can this be closed?

NicoAiko avatar Apr 23 '18 08:04 NicoAiko