node-testrail-api
node-testrail-api copied to clipboard
[Discussion] Provide response status code for each api call
Hello there again.
Do you mind if we add some more response to each api call? As it is right now, we can't deal different status codes as the package just doesn't sends them through with the response's body.
I'll do a Pull Request for it, if you don't mind. We can discuss further then.
Hi,
Yes, I don't mind. Don't forget to update the unit tests according to your changes.
Thanks for the help ! :)
#8
Now my typings fail.
Before:
let testrail: TestRail;
let tests: ITest[];
testrail = new TestRail(params);
tests = await testrail.getTests(123, {})
Now
let testrail: TestRail;
let tests: ITest[];
testrail = new TestRail(params);
tests = (await testrail.getTests(123, {}) as any).body
Sad.
@tymfear The types should be fixed by #10
I think this Issue can be closed now that #8 and #10 are merged
Can this be closed?