atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

fix: Azure DevOps plan (issue 5507)

Open bub3n opened this issue 6 months ago • 2 comments

what

Fix for #5507

why

In the Atlantis GitHub issue https://github.com/runatlantis/atlantis/issues/5507, there was a problem with downloading Git diff changes. The issue appeared after adding the top and skip arguments to the Git diff call. Previously, this endpoint did not return the changeCounts key when called with different arguments.

You can also see this in test scenario in azuredevops/git_test.go (link) which does not reflect that. And if you compare it to the Azure Devops documentation it's missing changeCounts key.

To fix this, I updated the GitCommitDiffs struct by changing the key to a string type, aligning it with other structs with changeCounts key for consistency.

tests

make test-all went thru without errors. And thanks to @leonardocaylent for testing the new build with the change in his environment.

references

bub3n avatar Jun 10 '25 13:06 bub3n