atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Published 20 hours ago • verified publisher icon runatlantis

fix: empty URL misrepresented as misconfiguration in the log

Open maximmasiutin opened this issue 6 months ago • 2 comments

references

  • Closes #5585

maximmasiutin avatar May 16 '25 13:05 maximmasiutin

@maximmasiutin any chance you can add a test for this?

nitrocode avatar May 17 '25 21:05 nitrocode

Ok, let me add a test.

maximmasiutin avatar Jun 12 '25 19:06 maximmasiutin

@nitrocode can you please help me and let me know where can I add these strings to a test case? I searched for any test by an existing substring Unable to update status at url and didn't find one. Is the test an absolute prerequisite for merging this pull request to resolve #5585 ?

maximmasiutin avatar Jul 06 '25 11:07 maximmasiutin

@nitrocode, coululd you plese merge this branch! I as mentioned earlier, I have not been able to find tests for log messages; however, if we should decide to make proper tests for log messages, I will be willing to participate to add those logs to various places, upon your guidaince, not jot to the place I initially pointed attention too. But to have a test for that isolated place - I have no idea on how to make it proerly let alone in the isolation.

maximmasiutin avatar Sep 26 '25 20:09 maximmasiutin