feat: do not react with emoji if "EmojiReaction" flag is empty

[CaioAugustoo]

what

• do not react comments with emoji in case "EmojiReaction" flag is empty

why

According to https://github.com/runatlantis/atlantis/pull/3360: "setting the emoji-reaction property to an empty string should disable comment reactions. This is not working, and the default eyes emoji continues to be used."

Also, as @jamengual mentioned: "It sounds weird to me that we will add another config flag to disable the emojis, I think this logic needs to be fixed. it should be disabled by default like all the other flags"

This PR makes "EmojiReaction" flag default value to an empty string. In case "EmojiReaction" flag is empty no comment will be reacted.

tests

• [X] I have tested my changes by running local tests with make test
• [X] I have tested my changes by running local tests with make build
• [X] I have tested my changes by running local tests in my own repository

references

• https://github.com/runatlantis/atlantis/issues/3457
• https://github.com/runatlantis/atlantis/issues/4357#issuecomment-2005555805

[jamengual]

Hi, @CaioAugustoo, why do we not make --emoji-reaction=" default to empty and fix the logic if needed instead of adding a flag to disable it?

The whole idea about my comment is that the flag should always be disabled by default.

[CaioAugustoo]

Hi, @CaioAugustoo, why do we not make --emoji-reaction=" default to empty and fix the logic if needed instead of adding a flag to disable it? The whole idea about my comment is that the flag should always be disabled by default.

@jamengual, Done! I made some changes. Let me know if it makes sense for you!

[CaioAugustoo]

Thank you @jamengual!

[chenrui333]

not quite sure why e2e tests run on the merge commit

[chenrui333]

Thanks @CaioAugustoo for your first contribution to atlantis! 💯