atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

revert: regression: remote ops detection TF v1.1

Open cypres opened this issue 1 year ago • 2 comments

Reverts linter change from https://github.com/runatlantis/atlantis/commit/56e38b415135c9f9e7b0df7fb52210f532afebda (#3690) which breaks TF v1.1 detection

what

Reverts a simple commit for a single file to fix remote operations for TF v1.1+

why

Without this revert you can't use Atlantis with Terraform Cloud v1.1+, see #2793 for why this was introduced in the first place.

tests

To prepare this I did git checkout 2e6758e -- server/core/runtime/plan_step_runner.go and picked the corresponding change from server/core/runtime/plan_step_runner_test.go

references

cypres avatar Jan 23 '24 07:01 cypres

@cypres there is also a test that validates that output. Please search for that text to add it there too. And would be nice to leave a comment since it’s that important!

GMartinez-Sisti avatar Jan 23 '24 08:01 GMartinez-Sisti

@cypres there is also a test that validates that output. Please search for that text to add it there too. And would be nice to leave a comment since it’s that important!

Thank you, I should have done that. Better now?

cypres avatar Jan 23 '24 08:01 cypres

/cherry-pick release-0.27

GenPage avatar Mar 05 '24 15:03 GenPage