atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Recommended metrics appear to be missing from `/metrics` endpoint

Open cblkwell opened this issue 2 years ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

The docs at https://www.runatlantis.io/docs/stats.html#available-metrics have a list of important metrics to track for Atlantis. However, when looking at the /metrics endpoint on our Atlantis hosts, none of those metrics appear to be exposed. We see plenty of other metrics, but none of the ones in the table listed as important.

Reproduction Steps

It should be pretty easy to verify this; I ran a simple curl | grep command to look for it (domain changed to protect the innocent):

$ curl https://atlantis.example.com/metrics |grep atlantis_cmd_autoplan_execution_error
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  283k    0  283k    0     0   877k      0 --:--:-- --:--:-- --:--:--  898k
$

As you can see, the request gets a great deal of other metrics, just not that one.

Logs

Environment details

We are running v0.26 with the terraform-aws-atlantis Terraform module on Fargate with ephemeral storage.

Server config:

repos:
- id: /.*/
  repo_config_file: atlantis-nonprod.yaml
  apply_requirements: []
  allowed_overrides: [apply_requirements, workflow]
  allowed_custom_workflows: true
  delete_source_branch_on_merge: true
metrics:
  prometheus:
    endpoint: "/metrics"

Repo config (name of project changed to protect the innocent):

version: 3
projects:
  - name: foo-bar
    dir: ./foo/bar

cblkwell avatar Nov 08 '23 16:11 cblkwell

Same on v0.27.1

Jeskz0rd avatar Apr 15 '24 21:04 Jeskz0rd