runatlantis
`GithubClient.GetCombinedStatusMinusApply()` returns false until all (including non-required) status checks are completed
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
- If you are interested in working on this issue or have submitted a pull request, please leave a comment.
Overview of the Issue
We recently enabled ATLANTIS_GH_ALLOW_MERGEABLE_BYPASS_APPLY but discovered this changes the behavior with non-required GitHub status checks. Previously, we could run atlantis apply while non-required checks were still pending. After enabling this flag, we have to wait for all of the optional checks to finish. I believe that's because Atlantis is first checking all of the checks before checking just the required checks in https://github.com/runatlantis/atlantis/blob/d5633662e9fa456429517613e4b785ee6c7e87f8/server/events/vcs/github_client.go#L400-L413.
Environment details
- Atlantis version: v0.24.3
- Deployment method: ECS
I beleive this was fixed with https://github.com/runatlantis/atlantis/pull/4193 The code now only check for required workflow or status checks.
