gh-allow-mergeable-bypass-apply checks all statuses

[andrewjamesbrown]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

When running atlantis apply with --gh-allow-mergeable-bypass-apply enabled, Atlantis responds with "Apply Failed: Pull request must be mergeable before running apply.".

In the Github UI, all status checks (apart from atlantis/apply) are successful, but when querying the GH API, several statuses are not "state": "success";

e.g. (removed PII):

  {
    "url": "https://api.github.com/repos/org/myrepo/statuses/83fae9ddc727f1f34a81ebff1832cbdd0ae32f33",
    "avatar_url": "https://avatars.githubusercontent.com/u/xxxxx",
    "id": 123456,
    "node_id": "SC_kwDOHzjQYc8AAAAE-Sli9A",
    "state": "pending",
    "description": "in progress...",
    "target_url": "https://atlantis.mydomain/jobs/57ec77c0-0478-4748-ab0d-f85af4de26ff",
    "context": "atlantis/pre_workflow_hook: Pre workflow hook #0",
    "created_at": "2023-02-02T19:28:42Z",
    "updated_at": "2023-02-02T19:28:42Z",

Reproduction Steps

In my PR, first I tried to atlantis apply when someone other than a CODEOWNER approved the PR, and then got a codeowner to approve, and then atlantis apply again.

Note that we also have a GH Action that runs on every commit that formats/lints and re-commits back to the repo - possibly this may have caused these pending actions.

Logs

Environment details

Atlantis version: 0.22.3 Running Atlantis in Hashicorp Nomad

Additional Context