atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Configurable plan timeouts

Open pratikmallya opened this issue 6 years ago • 12 comments

It would be nice to have atlantis discard plan automatically after a configured amount of time. This helps with workflows where you have many folks working on the same repo: you get a plan, apply it within 15 min or else it times out and you need to run plan again. This would let other users work on the plan without having to discard the plan manually from the atlantis UI

pratikmallya avatar Sep 12 '18 22:09 pratikmallya

Interesting, I like the idea. Would you like to be able to disable locking completely or would you prefer a timeout? @grobie would a timeout be more helpful to you than disabling completely?

lkysow avatar Sep 13 '18 16:09 lkysow

I think locking would still be useful; the workflow we have internally is:

  • Create a PR
  • work on it until its good; this requires plan to see if the proposed changes do what they're supposed to. Don't care for locking in this stage
  • once all the changes are in the PR, run plan and have atlantis lock it in
  • request a review and approval; if LGTM, then apply and merge

Hmm, thinking about this more, perhaps it would be better for atlantis not to lock by default, but only when requested by the PR e.g. atlantis plan -lock=true when the author thinks the plan is final and can be merged

pratikmallya avatar Sep 13 '18 21:09 pratikmallya

I think that makes a lot of sense this is technically not a terraform lock that we are talking about so I think that could be confusing for people to have atlantis plan -lock=true.

majormoses avatar Sep 13 '18 21:09 majormoses

@majormoses I think we're already past the point of causing confusion: atlantis plan and atlantis apply already mirror terraform plan and terraform apply

pratikmallya avatar Oct 31 '18 21:10 pratikmallya

Or are you saying that since the atlantis plan lock file is not a terraform thing it should not use the terraform-like syntax?

pratikmallya avatar Oct 31 '18 22:10 pratikmallya

Or are you saying that since the atlantis plan lock file is not a terraform thing it should not use the terraform-like syntax?

Correct since there is a lot similarities between between the two but are in fact different we should more clearly differentiate atlantis options from terraform options

majormoses avatar Oct 31 '18 22:10 majormoses

bumping this up, if this can be considered. 🙏

pavan-fp avatar Mar 07 '22 06:03 pavan-fp

Any movement on this one ?

IngussNeilands avatar Mar 31 '22 11:03 IngussNeilands

Just discovered this, and it would be extremely useful for us as well

SteezyCougar avatar Aug 11 '22 19:08 SteezyCougar

Bump +1, we are looking for a solution for stale, blocking plans. This would meet that need.

rcalosso avatar Sep 27 '22 16:09 rcalosso

Another use case for having timeouts on plan is that providers in a plan could be configured with temporary credentials (e.g.: retrieved from Vault with a TTL), so we know that after a specific amount of time, the plan will not be valid anymore.

cyrilgdn avatar Oct 19 '22 15:10 cyrilgdn