atlantis/plan status check does not work when autoplan is disabled

[innovia]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

We are a large team working on the same repo, having atlantis auto plan causes too much noise and too many locks

We turned atlantis auto plan off so that a reviewer can comment atlantis plan and then approve so the person can run atlantis apply

The problem is that the status check on github for atlantis/plan shows 0/0 planned projects which is inaccurate because there are changes.

We should have a way to see project changes also for cases when atlantis auto plan is disabled

It should read on the status check:

atlantis/plan ran 0/5 projects

Or it should not run apply without a plan, just like terraform does not let you run apply without a plan

It should consider the modified projects for the status checks even if the autoplan is disabled

Reproduction Steps

in atlanits.yaml set autoplan to false

autoplan:
      enabled: false
      when_modified:
          - ../../../../../modules/aws/datadog/*.tf*

make a new pr, the status check will mark 0/0 projects

Logs

Environment details

Additional Context

[AndreZiviani]

@innovia I've created a PR for something else but I think it should fix your problem (more specifically line 186) https://github.com/runatlantis/atlantis/pull/2053/files#diff-6583ec7260b28e573c74e18e783ee24ba8dce7d0a2e6929c105cc7e74d3d9c6fR186

[innovia]

Thanks @AndreZiviani I hope they will approve and merge that soon

[jamengual]

is this still happening with v0.19.8? this has been addressed

[innovia]

I didn't had a chance to try that again

[github-actions[bot]]

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.'