atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

Reaction emojis when running atlantis workflows

Open nitrocode opened this issue 5 years ago • 10 comments

I've been using the cloudposse chatops commands recently. When I run /readme-rebuild or similar, the chatops github action will first update my comment with 👀 to show that it has been seen, 🚀 when it has been dispatched, and finally 🎉 (or similar) when it completes.

Example: https://github.com/cloudposse/terraform-aws-alb-ingress/pull/26#issuecomment-645371322 Action code: https://github.com/cloudposse/actions/tree/master/github/slash-command-dispatch

I'd like to see something similar with atlantis chatops. Thank you!

Edit:

We can add the 👀 right before this

https://github.com/runatlantis/atlantis/blob/d1d1539ced062ccb8dc2a0368b4e4c802b6799b6/server/controllers/events/events_controller.go#L92-L93

We can add 🚀 right before this

https://github.com/runatlantis/atlantis/blob/d1d1539ced062ccb8dc2a0368b4e4c802b6799b6/server/controllers/events/events_controller.go#L303-L305

https://github.com/runatlantis/atlantis/blob/d1d1539ced062ccb8dc2a0368b4e4c802b6799b6/server/events/command_runner.go#L276

We can add an error emoji ❌ if an error is thrown (probably other places where we need to add an error)

https://github.com/runatlantis/atlantis/blob/d1d1539ced062ccb8dc2a0368b4e4c802b6799b6/server/events/command_runner.go#L276-L282

And if no error, we can add 🎉

Then need to set it up for gitlab, bitbucket, and any other VCS. Starting with github would be very nice!

nitrocode avatar Jun 17 '20 14:06 nitrocode

Dependabot is another great example.

https://github.com/cloudposse/geodesic/pull/551#issuecomment-584390508

osterman avatar Jun 17 '20 16:06 osterman

That would be super cool!

lkysow avatar Jun 19 '20 18:06 lkysow

yes please - updating comments instead of posting new comments for plans would also be a welcome change. It makes the conversation cleaner.

ghostsquad avatar Sep 17 '20 18:09 ghostsquad

updating comments instead of posting new comments for plans would also be a welcome change

yea, probably not a bad thing either, but should be a new feature request if not one already. The history is still preserved by github, and the noise would be so much less.

image

osterman avatar Sep 17 '20 19:09 osterman

what's with the screenshot?

Ya, I can make a new feature request.

ghostsquad avatar Sep 18 '20 05:09 ghostsquad

Created #1192

ghostsquad avatar Sep 18 '20 05:09 ghostsquad

I thought about this issue again today since github had issues with its webhooks. An additional benefit of this feature is that when github has issues sending out its web hooks in the future, you would know immediately github is having issues if you ran atlantis plan and a new emoji wasn't immediately added to your comment.

Ref: https://www.githubstatus.com/incidents/smn1qtqvbsb6

nitrocode avatar Oct 05 '22 17:10 nitrocode

I'll try to implement this as a PR.

marcusramberg avatar Oct 12 '22 09:10 marcusramberg

This ticket is only partially completed.

I think we have the ability to set an emoji only when Atlantis kicks off but no emoji when Atlantis is running or when it errors out

nitrocode avatar Oct 21 '23 05:10 nitrocode

Hi, I created this PR to allow setting an emoji when the command is running and an error occurs.

Daniel2000815 avatar Apr 25 '25 10:04 Daniel2000815