llama_index icon indicating copy to clipboard operation
llama_index copied to clipboard

Add support for Neptune Analytics as a Vector Store

Open bechbd opened this issue 3 months ago • 1 comments

Description

Added support for Neptune Analytics as a Vector Store

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • [ X] Yes
  • [ ] No

Version Bump?

Type of Change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [X ] Added new unit/integration tests
  • [ X] Added new notebook (that tests end-to-end)
  • [ X] I stared at the code and made sure it makes sense

Suggested Checklist:

  • [X ] I have performed a self-review of my own code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have made corresponding changes to the documentation
  • [X ] I have added Google Colab support for the newly added notebooks.
  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] I ran make format; make lint to appease the lint gods

bechbd avatar Mar 29 '24 22:03 bechbd

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks for the review, I believe that I have fixed all the issues.

bechbd avatar Apr 02 '24 03:04 bechbd