llama-hub icon indicating copy to clipboard operation
llama-hub copied to clipboard

feat: allow use of self-signed cert for MinIO server with MinioReader

Open ferdinandosimonetti opened this issue 1 year ago • 0 comments

Description

I've added cert_check as an option for MinioReader to avoid problems when the remote MinIO server has TLS enabled, but with a self-signed or untrusted certificate. How can I run my modified version of MinioReader locally, to perform some test?

Type of Change

Please delete options that are not relevant.

  • [X] Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Added new unit/integration tests
  • [ ] Added new notebook (that tests end-to-end)
  • [X] I stared at the code and made sure it makes sense

Suggested Checklist:

  • [ ] I have added a library.json file if a new loader/tool was added
  • [X] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I ran make format; make lint to appease the lint gods

ferdinandosimonetti avatar Feb 08 '24 12:02 ferdinandosimonetti