runhouse icon indicating copy to clipboard operation
runhouse copied to clipboard

[wip] Add animated spinners to long running operations.

Open rohinb2 opened this issue 10 months ago • 2 comments

Tried several libraries for this, none were that great.

this is the best library that prints above the text while it's running, and animates even without iterating through something

this also includes a timer, so many of our operations are timed explicitly

rohinb2 avatar Apr 12 '24 14:04 rohinb2

  • #725 Graphite 👈
  • #823 Graphite
  • #819 Graphite: 1 other dependent PR (#820 Graphite)
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

rohinb2 avatar Apr 12 '24 14:04 rohinb2

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/cluster.py

Function Unhandled Issue
check_server ValueError: Error installing runhouse on cluster node <205.196.17.2> ...
Event Count: 3
check_server ValueError: Error installing runhouse on cluster node <213.173.102.4> ...
Event Count: 2
check_server ValueError: Could not connect to server rh-inf2-8xlarge main in <...
Event Count: 1
check_server ValueError: Error installing runhouse on cluster node <10.128.0.2> ...
Event Count: 1
📄 File: runhouse/resources/module.py (Click to Expand)
Function Unhandled Issue
to ValueError: Error installing runhouse on cluster node <213.173.102.4> ...
Event Count: 2
to ValueError: Error installing runhouse on cluster node <91.199.227.82> ...
Event Count: 1
to AttributeError: 'str' object has no attribute 'check_server' main...
Event Count: 1
📄 File: runhouse/resources/packages/package.py (Click to Expand)
Function Unhandled Issue
to ValueError: Cluster must be started before copying data to it. main ...
Event Count: 1
📄 File: runhouse/servers/http/http_client.py (Click to Expand)
Function Unhandled Issue
call_module_method ImportError: libcuda.so.1: cannot open shared object file: No such file or directory ...
Event Count: 7
call_module_method ModuleNotFoundError: No module named 'vllm' __mai...
Event Count: 3
call_module_method RuntimeError: Pip install failed, check that the package exists and is available for your platform. ...
Event Count: 3
call_module_method FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/.rh/logs/llm.c_train_install@20240408@222700_4... ...
Event Count: 2
---

Did you find this useful? React with a 👍 or 👎

sentry-io[bot] avatar Apr 12 '24 14:04 sentry-io[bot]