Djordje Lukic

I just tested this with the latest code and it works ```console ➜ ~ docker image pull busybox:1.30.0 docker image tag busybox:1.30.0 busybox:latest docker image rm busybox:1.30.0 7964ad52e396: Download complete...

> > In other words, what specific benefits do we gain by explicitly supporting (and thus maintaining over time) these directly instead of supporting them implicitly via containerd's existing support?...

> In other words, what specific benefits do we gain by _explicitly_ supporting (and thus maintaining over time) these directly instead of supporting them implicitly via containerd's existing support? To...

> > The snapshotter-specific code just appends labels, so it is easier to maintain compared to logging drivers. > > If this is still a burden to get the PR...

> 1. This PR (cc @rumpl): Copy [`appendInfoHandlerWrapper`](https://github.com/containerd/containerd/blob/dadd203c255756d2208879088f7c61e1bee7d1f8/pkg/cri/sbserver/image_pull.go#L556-L624) to moby's codebase and use it. Add FIXME comment to use the function exported by containerd in the following-up patch. I can...

Can't approve my own PR but 👍 LGTM

> Looks like @rumpl forgot to DCO sign-off the commits 😉 Haha yes, remember, it was a friday afternoon so… The code is not ready to be reviewed, wanted to...

The failure is unrelated ``` #37 40.56 E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/pool/main/g/gcc-10-cross/gcc-10-arm-linux-gnueabi-base_10.2.1-6cross1_amd64.deb Error reading from server - read (104: Connection reset by peer) [IP: 146.75.30.132 80] #37 40.56 E: Unable...

> doh! > > Looks like something needs to be fixed up; > > ``` > #23 55.02 daemon/containerd/mount.go:24:2: tempMountLocation declared but not used > #23 55.02 daemon/containerd/mount.go:26:28: undefined: tempDir...

Hm... Some of the checks fail because of `fatal: detected dubious ownership in repository at '/go/src/github.com/docker/docker'`, not sure what is going on