API: POST /rooms/:room_id/forget

[jimmycuadra]

[taylskid]

Hi, I am interested in working on ruma, and thought this would be a good issue to tackle for my first one. I had some quick questions before I started though:

• the /forget endpoint and the /leave endpoint are both in the "leaving a room category" on the API spec, but /leave is currently implemented in join.rs. Should I break /leave into a new file and abstract the actual "leaving" logic since /forget implies a leave as well?
• synapse has a column in the database to denote if a channel has been forgotten or not. Is this the avenue that should be taken here as well?
• the spec says that rooms where all users have forgotten them are eligible for deletion by the homeserver; is this a feature that needs to be implemented right away as well?

Thanks for your time, looking forward to hopefully hacking on ruma some!

[jimmycuadra]

Thanks for the interest! To answer your first two questions: yes, those both sound like fine approaches. For the third question, it wouldn't be necessary to include that functionality in the same PR. In fact, work that could be done out-of-band from API requests will probably be put in a separate application once we get to the point of working on things like that.