gsts icon indicating copy to clipboard operation
gsts copied to clipboard

Sort by ARN when interactively prompting so that accounts are grouped together when multiple roles exist

Open spasam opened this issue 3 years ago • 6 comments

spasam avatar Feb 15 '22 19:02 spasam

@ruimarinho could you please take a look at this simple change? Thanks

spasam avatar Feb 15 '22 19:02 spasam

@spasam I like the idea but I would prefer if this was done under credentials-manager.js to make it testable (https://github.com/ruimarinho/gsts/blob/master/credentials-manager.js#L89). Can you make that change please?

ruimarinho avatar Feb 16 '22 19:02 ruimarinho

@spasam I like the idea but I would prefer if this was done under credentials-manager.js to make it testable (https://github.com/ruimarinho/gsts/blob/master/credentials-manager.js#L89). Can you make that change please?

Sure. Just made the change. Unrelated change in index.js is just replacing tabs with spaces.

spasam avatar Feb 16 '22 19:02 spasam

Thank you! Could you please add a test to ensure the feature remains covered? Appreciated!

ruimarinho avatar Feb 16 '22 19:02 ruimarinho

Yeah, was just looking at that. Looks like I can re-order stuff in existing test and probably also add new one

spasam avatar Feb 16 '22 19:02 spasam

Updated:

$ npm test

> [email protected] test
> jest

 PASS  ./credentials-manager.test.js
 PASS  ./parser.test.js

Test Suites: 2 passed, 2 total
Tests:       25 passed, 25 total
Snapshots:   0 total
Time:        0.418 s, estimated 1 s
Ran all test suites.

spasam avatar Feb 16 '22 19:02 spasam

This is nice developer experience @spasam. Thank you :)

ruimarinho avatar Aug 08 '22 18:08 ruimarinho