TwitterBootstrapBundle icon indicating copy to clipboard operation
TwitterBootstrapBundle copied to clipboard

Make bootstrap variables changeable simply

Open azr opened this issue 13 years ago • 14 comments

It would be great ! :)

http://twitter.github.com/bootstrap/less.html#variables

azr avatar Feb 22 '12 08:02 azr

I will add this when i will have some time ;-)

ruian avatar Feb 22 '12 09:02 ruian

@ruian , any ideas how to implement it, or where to make 'modifications'? (config.yml, or as an argument to a console?)

maybe it would be better just implement --append-less switch to :compile?

andrewtch avatar Feb 23 '12 16:02 andrewtch

I don't know if it's a good idea to put less variables into config.yml. I think it's better to a variables.less reference into the user bundle. And use it instead of default twitter\bootstrap\v2\less\variables.less

ruian avatar Feb 24 '12 09:02 ruian

Forcing users to copy whole variables.less is a pain.

what about twitter:bootstrap:compile v2 --apend-less MyCoolBundle:lessvars.less (which just adds src\MyCoolBundle\Resources\less\lessvars.less to variables before compilation?)

andrewtch avatar Feb 26 '12 19:02 andrewtch

Yes it could be a solution

ruian avatar Feb 26 '12 19:02 ruian

Yes and you could mix the two solution, if there is no --apend-less you could just check in the configurations.

And that would make the Bundle and cool less compiler :p

edit : It would be great too to be able to set se default boostrap version in the configuration file too

azr avatar Feb 27 '12 06:02 azr

like:

ruian_bootstrap:
  lessvars: |
    @boo: 123
    @foo: 456

?

andrewtch avatar Feb 27 '12 08:02 andrewtch

Something more like :

ruian_bootstrap:
 twitter_bootstrap_version: V2
 lessfile: ../src/Acme/Bundle/Resource/Public/less/file.less 
  #or
 lessdir: ../src/Acme/Bundle/Resource/Public/less/my_awesome_stylesheet/

Not sure if lessing a whole directory is possible though ?

azr avatar Feb 28 '12 08:02 azr

With your way using shortcuts will be easier

AcmeBundle:file.less instead of ../src/Acme/Bundle/Resource/Public/less/file.less

But important i think this addon is just for manipulating bootstrap's variables. not to includes yours into bootstrap.

ruian avatar Feb 28 '12 09:02 ruian

Indeed. Manipulating whole boostrap would add more problems like 'append or prepend user files?' 'where to append user files, in bootsrap.less or variables.less'?

andrewtch avatar Feb 28 '12 09:02 andrewtch

Yes I think you're right, it would be difficult to know what to do with everything. And in fact I was more thinking about adding completely different less projects to be compiled in a different css file

ruian_bootstrap:
 ...
 less_projetcs:
  my_acme_project:
   dir: AcmeBundle:dir.less
   params: ~
   ...

But may be that's not the same project and certainly not the right issue

azr avatar Feb 29 '12 09:02 azr

Well, then you should need lesscompiler bundle instead of bootstrap bundle )

andrewtch avatar Feb 29 '12 10:02 andrewtch

Yep @andrewtch i agree

ruian avatar Feb 29 '12 10:02 ruian

It seems this Issue was resolved (in terms of this 'bundle should not do this')

#closerequest

Blackskyliner avatar Dec 14 '12 09:12 Blackskyliner