website-dark-mode-switcher icon indicating copy to clipboard operation
website-dark-mode-switcher copied to clipboard

Published 20 hours ago • verified publisher icon rugk

Package Chrome Extension As Well

Open Justin-CB opened this issue 4 years ago • 5 comments

Because you use the WebExtensions API, which is more or less standardized across browsers, it makes sense to also package this as a chrome extension. This might require some work, as chrome provides a chrome object, rather than a browser object, but the chrome object supports almost all of the same WebExtension API's.

Justin-CB avatar Nov 06 '20 15:11 Justin-CB

Sure, any PRs are always appreciated! See https://github.com/rugk/offline-qr-code/issues/59 for reasoning and information on polyfills etc.

rugk avatar Nov 06 '20 21:11 rugk

Is Chrome supported???

mrl24730 avatar May 14 '21 18:05 mrl24730

Not yet, but PR's are very welcome though if one wants to try to make it work.

Also see another add-on in development currently, that also tries to support Chome/ium browsers.

rugk avatar May 14 '21 19:05 rugk

Note that Chrome/ium support may be tricky, given not all APIs are supported by Chrome/ium browsers.

rugk avatar Dec 07 '21 22:12 rugk

...especially as v2.0 uses a new browser setting/API that only Firefox has, for now. So porting the add-on in the current state seems quite impossible. Only the old mechanic from v1.3 could possibly be ported, but would have to be maintained separately or so, which I'd like to avoid.

rugk avatar Dec 08 '21 00:12 rugk