offline-qr-code icon indicating copy to clipboard operation
offline-qr-code copied to clipboard

Published 20 hours ago • verified publisher icon rugk

Does not initially indicate if too much text selected on Linux(?)

Open Gitoffthelawn opened this issue 5 years ago • 12 comments

Bug description

When creating a QR code from too much selected text, does not generate an error.

Steps to reproduce

  1. Go to any page with plenty of text.
  2. Press Ctrl+A
  3. Generate a QR code

Actual behavior

No error until you try to modify the text.

Expected behavior

Error that string is too long.

System

Operating system: Windows Browser and version: Firefox 72.0.2 Add-on version: 1.6

Gitoffthelawn avatar Jan 24 '20 11:01 Gitoffthelawn

Cannot reproduce. If I use https://de.wikipedia.org/wiki/Wikipedia:Hauptseite and use the context menu to create the QR code, it does show me the error instantly. Could you maybe specify the exact site, you've used?

grafik

Edit: This is a Windows device.

rugk avatar Jan 24 '20 13:01 rugk

That's funny, I tested it on Wikipedia too! :)

Here's the page I used: https://en.wikipedia.org/wiki/QR_code

I only got the error after I tried to modify the text.

I don't recall if I had the toolbar button on the in the overflow menu or not during that test. I have to go right now, otherwise I would check it for you.

Gitoffthelawn avatar Jan 24 '20 14:01 Gitoffthelawn

Okay, now can reproduce the issue with both Wikipedia pages. Strangely, I could not with the dev version before. That is strange…

Maybe a timing issue/race condition?

On Fedora 31, Firefox 72.

rugk avatar Jan 26 '20 15:01 rugk

Yes, it could be a race condition. It happens every time for me, which is interesting that it doesn't do the same for you. I'm glad you mentioned that it happens on both pages for you.

Gitoffthelawn avatar Jan 27 '20 05:01 Gitoffthelawn

Yeah repdocuible on the device I mentioned above, but not on another Windows device. 🤔

rugk avatar Jan 27 '20 07:01 rugk

Same version of Windows and browser on each?

Gitoffthelawn avatar Jan 28 '20 04:01 Gitoffthelawn

Actually no, only reproducible on Linux (Fedora), not on Windows here. Same Firefox though. 🤔

rugk avatar Jan 28 '20 08:01 rugk

Hi,

confirmed on Ubuntu 20.04, Firefox 77.0.1, Offline QR Code Generator 1.7 (checked via about:telemetry#environment-data-tab_addons as I do not know any other way to see the installed version).

muxator avatar Jun 24 '20 20:06 muxator

@muxator Thank you for the confirmation. Mozilla has made it a little less obvious where to quickly find the version numbers for installed extensions. The trick is to go to about:addons, and then hover the cursor over the name of the extension. The extension's version should pop up in a tooltip.

Gitoffthelawn avatar Jun 27 '20 04:06 Gitoffthelawn

…or open the extension page details and scroll down to the bottom. There, everything is.

rugk avatar Jun 29 '20 13:06 rugk

@rugk That too! :)

Gitoffthelawn avatar Jun 30 '20 13:06 Gitoffthelawn

I checked the extension version using the three methods (yay). It's 1.7, indeed.

Here's a screen capture when replicating the issue. The context menu got cut off. The command I'm invoking is "QR code from selection".

Peek 2020-06-30 23-27

  • kubuntu 20.04
  • firefox 77.0.1
  • offline qr code 1.7

muxator avatar Jun 30 '20 21:06 muxator