rugk
rugk
You can also try to look which commit introduced that behaviour, but I am not sure whether this is helpful…
Actually the Contributing.md [has a small part for getting starting](https://github.com/rugk/offline-qr-code/blob/master/CONTRIBUTING.md#getting-started). I guess you checked that out already. So for testing/changing things, you actually need to modify the source code in...
You don't need to run any build script. You can load the add-on instantly, you just have to [clone](https://help.github.com/articles/cloning-a-repository/) the repo here and you can load the `manifest.json` directly. How...
If you can describe it in a compact way, it would certainly also not hurt to describe the cause in this issue, even if you have not a PR ready...
Might be the culprit, but actually the `applyOptionLive()` method should only apply custom stuff of options, i.e. not every option needs to be defined there just to be saved/reset. I've...
@TauseefMalik BTW, can you still reproduce this with the latest version? Note we now have proper unit tests for all used ([TinyWebExt](http://github.com/tinywebex/)) modules and they are also properly implemented.
I suspect https://github.com/rugk/offline-qr-code/issues/180 could fix this issue. Needs verification though… :smiley:
Result: Still fails. Also when updating AddonSettings and AutomaticSettings modules, the initial reset now works, but when I press "Undo", it does not correctly reset the options to their previous...
Yeah, thanks. Sure. Let me know if you have any questions. :smiley:
@mitcheesta Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is.