rugk

Results 1590 comments of rugk

> Receiver detect referrer and window.opener then prompt an encrypt key. Both things are regularely disabled by users for privacy reasons (or e.g. in Tor Browser). Also I don't understand...

Hmm, it goes into the same direction as https://github.com/PrivateBin/PrivateBin/issues/2, which seems to be @elrido's favorite feature request. --- Re-reading this idea here the use case seems to be this one:...

@ZerooCool If you want, feel free to review this using GitHub's review tool (see "files changed" tab).

So would this really solve all the OpenGraph-related issues you've linked? I just don't get *why* it does so? But if it helps, we would be happy to appreciate a...

> What is a PR? For information on how to propose PRs, see https://help.github.com/articles/proposing-changes-to-your-work-with-pull-requests/. See [this article](https://help.github.com/articles/merging-an-upstream-repository-into-your-fork/) for how to merge upstream changes into your fork. This way, you can...

> but, I don't know how, to use the variable of the configuration file in the PHP code of the template. This may help you: https://github.com/PrivateBin/PrivateBin/wiki/Development#creating-new-configuration-options

Looks good, maybe rename it to "path" or so and explain in the config that this only applies to the meta tags, but except of that it looks good.

Nah, let's only close this when the PR to fix this is merged. You can (automatically) [let issues close](https://help.github.com/articles/closing-issues-via-commit-messages/) when a PR is merged by adding some "magic" text to...

> , I guess the styleci is complaining mixed use of tab and space? Yes, that's sometimes annoying. I guess you know you should use the [editorconfig plugin or so](https://editorconfig.org/#download)...

Hehe, it's all right, that's what reviews are for. Even though these typos in comments are not a problem at all… :upside_down_face: