Using the Add-on 0.9.1 with Thunderbird 102.0b7 - Hitting enter once when composing an email has the effect of hitting enter twice

[dbonner]

How I tested this:

I tried this on Windows and also on Linux (Thunderbird for aarch64 built from source)

1. Run Thunderbird without the Awesome Emoji Picker add-on installed.
2. Make sure there is no tick in the setting: "Use Paragraph format instead of Body Text by default". (This is under Settings->Composition->HTML Style)
3. Hit "Write" to compose a new email.
4. Type "This is the first line".
5. Hit Enter once.
6. Type "This is the next line".

The result is as you would expect (i.e. hitting enter just causes you to go to the next line immediately below): This is the first line This is the next line

7. Discard the previous email that you were composing.
8. Install the Awesome Emoji Picker addon (version 0.9.1)
9. Hit "Write" to compose a new email.
10. Type "This is an example".
11. Hit Enter once.
12. Type "This is the next line".

Every time you hit the Enter key, Thunderbird will issue 2 x Enter commands, i.e. there is a blank line between the first line you entered and the next line like this: This is the first line

This is the next line You can hit the backspace key after hitting enter to eliminate the extra line between the sentences. You can also use Shift+Enter to cause there to be no space between lines.

13. Uninstall the Awesome Emoji Picker Addon. Then Thunderbird returns to normal. Hitting enter works as it should.

[tdulcet]

Thanks for the bug report and for testing the add-on in Thunderbird 102 beta! Also, thanks for the detailed steps to reproduce, that is very helpful. I am able to confirm this issue when disabling the "Use Paragraph format instead of Body Text by default" option in Thunderbird 102 beta. However, I am not able to reproduce it in Thunderbird 91, so it is most likely a regression in Thunderbird. You could use mozregression to find the regressing commit and then report the bug to them on BMO.

Note that this is due to the experimental Emoji autocorrect feature, which is likely going to be either disabled by default or removed in the next version of the add-on, while it is further tested (see https://github.com/rugk/awesome-emoji-picker/pull/93#issuecomment-1153708883). Hopefully this will be in time for the official release of Thunderbird 102.

[nichu42]

I have the same problem with Thunderbird 102 release. Paragraph format is not checked. The problem disappears when disabling the emoji picker plug-in. It also happens if Emoji auto-correction is disabled.

[nichu42]

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=1777183

[tdulcet]

@nichu42 - Thanks for the additional information and for filing that bug report on BMO. The add-on has not changed, so something was obviously broken between TB 91 and 102. As I said above, it would be very helpful if someone could use mozregression to find the regressing commit. TB 102 was just released today, so it will likely be another month or two at least before the automatic upgrade is enabled for users.

It is currently not possible to completely disable the Emoji autocorrect feature, but our other add-on has a similar Unicode autocorrect feature and a few weeks ago I submitted a PR to disable that by default (see https://github.com/rugk/unicodify/pull/72). It is currently just waiting on @rugk's review and then we would be able to make that same change here...

[tdulcet]

I just published v0.9.2 on ATN which disables the emoij autocorrect feature by default.

@rugk - This issue can now be closed. For reference, the changes are temporally in this branch here while I wait for you to finish reviewing my existing PRs.

@dbonner and @nichu42 - You should automatically get the update within 24 hours or you can force it from the Add-ons manager.

[rugk]

This issue can now be closed. For reference, the changes are temporally in this branch here while I wait for you to finish reviewing my existing PRs.

Hm what? May you just rebase it on master or so? Or which PR still needs my eyes?

[tdulcet]

Hm what? May you just rebase it on master or so? Or which PR still needs my eyes?

Around a quarter of the changes in that branch were in #126 and the PRs with the rest of the improvements are still waiting on #127, as they depend on changes made there... I will rebase #93 after https://github.com/rugk/unicodify/pull/72 is approved.

[tdulcet]

For anyone following this issue, I just noticed that the regression seems to have been fixed in Bug 1778091 which landed in Thunderbird 104. Unfortunately, they did not uplift that fix to Firefox/Thunderbird 102 ESR, so anyone wanting to use the Emoji autocorrect feature with that affected "Body text" format option would need to use either Thunderbird Beta or Daily until Thunderbird 115 ESR is released next year.