on_ruby icon indicating copy to clipboard operation
on_ruby copied to clipboard

Include full address in ical event

Open timkaechele opened this issue 1 year ago • 2 comments

What it changes

This PR changes the ical events to actually include the address if present and only in the absence of a full address fall back to the name of the location

Why?

Because ruby user group events in Berlin are always at a different location, and I have trouble finding the place and the name of the location is not as helpful compared to an actual address your phone's calendar can help you find.

Bildschirmfoto 2024-02-03 um 14 43 37

timkaechele avatar Feb 03 '24 13:02 timkaechele

@timkaechele could you rebase this please. also i would like to have the name of the venue included in the address. its very common that companies are co-located at the same address, so why would you remove that information? just compact.join(', ') all available address components including the name.

phoet avatar Nov 29 '24 09:11 phoet

@timkaechele could you rebase this please. also i would like to have the name of the venue included in the address. its very common that companies are co-located at the same address, so why would you remove that information? just compact.join(', ') all available address components including the name.

That makes sense. I thought the address itself would be sufficient, because at least in Berlin the company hosting the meetup usually puts up signs, but I guess that is not true for all meetup groups

timkaechele avatar Nov 30 '24 10:11 timkaechele