Elastica icon indicating copy to clipboard operation
Elastica copied to clipboard

Add rewrite param setters to all relevant queries

Open Sharptsa opened this issue 9 months ago • 5 comments

I recently had to play with the rewrite params on a few queries and only the Wildcard and QueryString classes have a setter for this param.

This PR adds setters for the rewrite params for all relevant the relevant Query classes where it is missing (Prefix, Regexp and Fuzzy), based on the Elasticsearch documentation https://www.elastic.co/docs/reference/query-languages/query-dsl/query-dsl-multi-term-rewrite. As well as adding constants for all the possible values for this param.

Sharptsa avatar Apr 18 '25 15:04 Sharptsa

For the CI runs, looks like we need do update Ubuntu first, we got the following error message:

This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see https://github.com/actions/runner-images/issues/11101

ruflin avatar Apr 23 '25 05:04 ruflin

I opened a PR with a fix here: https://github.com/ruflin/Elastica/pull/2243

ruflin avatar Apr 24 '25 06:04 ruflin

I just merged https://github.com/ruflin/Elastica/pull/2243 which should fix the CI issue. Can rebase / update the branch?

ruflin avatar Apr 25 '25 20:04 ruflin

This new push slipped through on my end. Any chance you could rebase this on 9.x so we can get this into 9.x and backport it from there to 8.x?

ruflin avatar Jul 25 '25 17:07 ruflin

I changed the target of this PR to go against 9.x. We can always backport to 8.x afterwards.

ruflin avatar Jul 27 '25 18:07 ruflin