Elastica
Elastica copied to clipboard
Get default values from index setting api
Problem:
I need to retrieve index settings like 'max_result_window' but in the response body default value is not returned, in order to fetch the default value need to add the include_default query param to /_setting request.
Suggestion:
We can add the ability to set flag include_default(or by default set to true?) and change the behavior of \Elastica\Index\Settings::get method
- search setting value in the
settingkey as before - if the value is not found on 1 step then search setting value in default key.
What do think about this? is it will be useful for this lib?
I have prepared PR: https://github.com/ruflin/Elastica/pull/2115
Closing as this merged.