Elastica icon indicating copy to clipboard operation
Elastica copied to clipboard

[6.x] Fix inner hits source filtering test

Open deguif opened this issue 4 years ago • 5 comments

deguif avatar Mar 23 '21 14:03 deguif

This PR goal was to test the new 6.8.1 version of elasticsearch/elasticsearch published yesterday by @ezimuel . It seems it's still breaking on class Elasticsearch\Endpoints\Indices\ForceMerge which is not found anymore.

PS: It seems it's now Elasticsearch\Endpoints\Indices\Forcemerge with lowercased m 🤔

deguif avatar Mar 23 '21 14:03 deguif

@ezimuel Don't know what to do on my side. This class renaming from Elasticsearch\Endpoints\Indices\ForceMerge to Elasticsearch\Endpoints\Indices\Forcemerge seems a bug on 6.8.1.

Recent version 7.12.0 has no issue as it uses the Elasticsearch\Endpoints\Indices\ForceMerge class naming.

deguif avatar Mar 24 '21 12:03 deguif

Looks like ForceMerge was renamed in https://github.com/elastic/elasticsearch-php/commit/2da5f9337a269113954a84fe8e79ea6843f0e7c3#diff-c4834c4ebd492607a0af1ab55c7575c6a84323f8be87ca6f7f8833cf4ffc2675

Screenshot 2021-03-25 at 14 47 28

reedy avatar Mar 25 '21 14:03 reedy

@deguif just commented here https://github.com/elastic/elasticsearch-php/issues/1131#issuecomment-841319667

ezimuel avatar May 14 '21 15:05 ezimuel

Just released elasticsearch-php 6.8.2 including the fix for this issue (https://github.com/elastic/elasticsearch-php/pull/1151).

ezimuel avatar Jul 14 '21 14:07 ezimuel