ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

Tab key behavior from Adobe Flash Player not present in Ruffle

Open Sunlitspace542 opened this issue 4 years ago • 13 comments

Describe the feature Provide a clear and concise description of your feature request. Why would this feature be useful? Does the feature involve the desktop build, the web build, or both?

This was a feature the original Flash Player had, if you press the tab key, it cycles through each clickable item, highlighted with a yellow box around the item. pressing enter "clicks" on the item. Screenshot attached with example of what I'm talking about using a Flash projector: image

Sunlitspace542 avatar Oct 09 '21 16:10 Sunlitspace542

Would be nice.

eris-webserv avatar Dec 06 '21 14:12 eris-webserv

I agree

mero09-99 avatar Aug 02 '22 15:08 mero09-99

This is vital for finding all the Homestar Runner easter eggs.

KazyEXE avatar Sep 21 '22 13:09 KazyEXE

Kind of curious how hard this would be to implement. Has anyone looked into this? What does the tab key do now?

battaglia01 avatar Nov 26 '22 03:11 battaglia01

This is very important for accecibility

ActionWavele avatar Dec 12 '22 15:12 ActionWavele

What does the tab key do now?

Nothing, looks like

Atario avatar May 06 '23 04:05 Atario

Any updates on this? This and the zoom functionality are some of the most noticeable pain-points with ruffle compared to native flash.

VL4DST3R avatar Nov 25 '23 22:11 VL4DST3R

This is ultra-very important, and maybe even more important than the mouse support. And, this is a bug report, not an enhancement request.

rikkoooo avatar Dec 30 '23 01:12 rikkoooo

Ok. Does anyone have any idea how to implement this? Where would one poke around to do this?

battaglia01 avatar Dec 30 '23 04:12 battaglia01

Implementation status:

  • [x] Tab key support
    • https://github.com/ruffle-rs/ruffle/pull/15542
    • https://github.com/ruffle-rs/ruffle/pull/15737
  • [x] Visual highlight around the tabbed element
    • https://github.com/ruffle-rs/ruffle/pull/15717
  • [ ] AVM1 support
    • https://github.com/ruffle-rs/ruffle/pull/15542
    • https://github.com/ruffle-rs/ruffle/pull/15580
    • https://github.com/ruffle-rs/ruffle/pull/15618
    • https://github.com/ruffle-rs/ruffle/pull/15838
    • dispatching events on focus
  • [ ] Analysis and implementation of a proper automatic order
    • https://github.com/ruffle-rs/ruffle/pull/15810
    • https://github.com/ruffle-rs/ruffle/pull/15864
    • make the order even better?
  • [ ] Tabbed element navigation (Space, Enter, Arrows)
  • [ ] AVM2 support
  • [ ] It seems that focusing elements by Tab triggers some additional events?
  • [ ] It seems that FP has some weird logic related to the first focused element
  • [ ] Should FocusTracker hold a weak reference to the focused object?

kjarosh avatar Mar 12 '24 16:03 kjarosh

does it work across other OSes?

Croworbit avatar Mar 12 '24 17:03 Croworbit

does it work across other OSes?

This feature is platform-independent. Should work on every OS and on web (although I am not able test it on all OSes).

kjarosh avatar Mar 12 '24 17:03 kjarosh

Note: It works on the browser version (as in the swf file can detect its being pressed)

abigailraven avatar Mar 28 '24 20:03 abigailraven