ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

tests: Add compilation scripts for tests

Open kjarosh opened this issue 1 year ago • 4 comments

I thought I'd include the scripts I used for compiling tests. They might come in handy when editing a test in the future!

kjarosh avatar Aug 21 '24 22:08 kjarosh

This is great and awesome and cool! 🥳 But ... do we need 50 of it, in a random subset of test folders? 🤔

torokati44 avatar Aug 21 '24 22:08 torokati44

This is great and awesome and cool! 🥳 But ... do we need 50 of it, in a random subset of test folders? 🤔

Well... those tests are authored in different ways, some of them are hand crafted, some of them are made in JPEXS, some of them compiled with a script, some of them made with Flash.

I added these scripts for tests that were compiled with those scripts (they were originally .gitignore'd). Additionally, not all of those 50 scripts are identical, some have different CLI options. So considering that these scripts are not identical and they are only added for tests that use them, I do not see any other option to commit them :/

kjarosh avatar Aug 21 '24 22:08 kjarosh

I am not going to use docker for compiling so this is just superfluous noise for me.

evilpie avatar Aug 22 '24 07:08 evilpie

47 of them are just

docker run -it --rm -v ${PWD}:/app instrumentisto/flex-sdk mxmlc -output test.swf -compiler.debug=true Test.as

and the remaining three are the exact same command but with a SWF version specified. Sorry, but seeing as the command is mostly intuitive, and this has even more potential to confuse people (we already sometimes have Test.as, test.fla, and other files in the test folders), I don't agree with adding these.

Lord-McSweeney avatar Aug 24 '24 00:08 Lord-McSweeney

How about adding this docker invocation to CONTRIBUTING.md?

If there are any instructions relevant to building individual tests, I usually add them to .as (or .toml).

adrian17 avatar Aug 29 '24 19:08 adrian17

Closing due to lack of interest

kjarosh avatar Sep 04 '25 19:09 kjarosh