ruffle icon indicating copy to clipboard operation
ruffle copied to clipboard

Published 20 hours ago • verified publisher icon ruffle-rs

avm2: stub desktop AIR APIs

Open Mesteery opened this issue 1 year ago • 6 comments

Mesteery avatar Jul 29 '24 13:07 Mesteery

Can you remove the AIR argv handling from this PR? I think we shouldn't combine it.

evilpie avatar Jul 29 '24 22:07 evilpie

Can you remove the AIR argv handling from this PR? I think we shouldn't combine it.

I put air argv handling in the same PR because it's needed by NativeApplication. But yes I can split if you want.

Mesteery avatar Jul 29 '24 23:07 Mesteery

This PR is huge and does a lot of different stuff in one commit. @Mesteery if you split it up it will be easier and quicker to review. Please add least split out the air_arguments and screen_size code.

evilpie avatar Aug 21 '24 18:08 evilpie

Split into #17609 and #17608

Mesteery avatar Aug 22 '24 09:08 Mesteery

Thanks you for your review. I've normally addressed all the changes

Mesteery avatar Aug 24 '24 23:08 Mesteery

Thank you! 🥳 I'll take another look, and still have two files left to read through - but gotta sleep first. 😌😴

torokati44 avatar Aug 24 '24 23:08 torokati44

Thank you for addressing all the review notes!

torokati44 avatar Sep 08 '24 10:09 torokati44